Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images of text, tweak the assumption #2107

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Images of text, tweak the assumption #2107

merged 4 commits into from
Dec 7, 2023

Conversation

WilcoFiers
Copy link
Member

From my annual review. 1.4.9 should not be in the assumption since the exception we're assuming doesn't occur is not part of SC 1.4.9.

Need for Call for Review: 1 week, not just editorial


How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@WilcoFiers WilcoFiers added the Review Call 1 week Call for review for small changes label Oct 24, 2023
@Jym77
Copy link
Collaborator

Jym77 commented Dec 7, 2023

Call for review has ended. Merging.

@Jym77 Jym77 merged commit db1235b into develop Dec 7, 2023
2 checks passed
@Jym77 Jym77 deleted the image-text-editorial branch December 7, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Call 1 week Call for review for small changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants