Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add background info to meta refresh rules (bc659a, bisz58) #2159

Merged
merged 3 commits into from Apr 25, 2024
Merged

Add background info to meta refresh rules (bc659a, bisz58) #2159

merged 3 commits into from Apr 25, 2024

Conversation

carlosapaduarte
Copy link
Member

Adds background info describing what a meta refresh is, to the meta refresh rules

Closes issue(s):

Need for Call for Review:

  • This will not require a Call for Review

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@carlosapaduarte carlosapaduarte added Rule Update Use this label for an existing rule that is being updated reviewers wanted labels Feb 5, 2024
@carlosapaduarte carlosapaduarte self-assigned this Feb 5, 2024
Jym77
Jym77 approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@Jym77 Jym77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to say we should link to the specs… But we do so in the Expectation, and they are totally unreadable 😓 So, this is good.

@Jym77 Jym77 added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Apr 18, 2024
@Jym77
Copy link
Collaborator

Jym77 commented Apr 18, 2024

Call for review ends on April 25th.

@Jym77
Copy link
Collaborator

Jym77 commented Apr 25, 2024

Call for review has ended, merging.

@Jym77 Jym77 merged commit 80998b2 into develop Apr 25, 2024
2 checks passed
@Jym77 Jym77 deleted the add-background-meta-refresh branch April 25, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jym77 Jym77 Jym77 approved these changes

@tbostic32 tbostic32 tbostic32 approved these changes

@giacomo-petri giacomo-petri giacomo-petri approved these changes

@WilcoFiers WilcoFiers Awaiting requested review from WilcoFiers

Assignees

@carlosapaduarte carlosapaduarte

Labels
Review Call 1 week Call for review for small changes Rule Update Use this label for an existing rule that is being updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

meta-refresh rules, add explanation of meta element [bisz58] [bc659a]
4 participants
@carlosapaduarte @Jym77 @tbostic32 @giacomo-petri