Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links with identical accessible names and same context serve equivalent purpose" [fd3a94]: Reduced images size for failed examples [4,8] #2178

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Links with identical accessible names and same context serve equivalent purpose" [fd3a94]: Reduced images size for failed examples [4,8] #2178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions _rules/links-with-identical-names-and-context-serve-equivalent-purpose-fd3a94.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,8 +289,8 @@ These two HTML `a` elements have the same [accessible name][] and [context][prog
<div>
<span style="text-align:center;">Contact us</span>
<span style="display:flex; justify-content:space-around;">
<img src="/test-assets/shared/chat.png" alt="Chat" style="width:50%;" />
<img src="/test-assets/shared/phone.png" alt="Phone" style="width:50%;" />
<img src="/test-assets/shared/chat.png" alt="Chat" style="max-width:50px;" />
<img src="/test-assets/shared/phone.png" alt="Phone" style="max-width:50px;" />
</span>
<span style="display:flex; justify-content:space-around;">
<a
Expand All @@ -315,8 +315,8 @@ These two HTML `a` elements have the same [accessible name][] and [context][prog
<div>
<span style="text-align:center;">Contact us</span>
<span style="display:flex; justify-content:space-around;">
<img src="/test-assets/shared/chat.png" alt="Chat" style="width:50%;" />
<img src="/test-assets/shared/phone.png" alt="Phone" style="width:50%;" />
<img src="/test-assets/shared/chat.png" alt="Chat" style="max-width:50px;" />
<img src="/test-assets/shared/phone.png" alt="Phone" style="max-width:50px;" />
</span>
<span style="display:flex; justify-content:space-around;">
<a href="/test-assets/links-with-identical-names-serve-equivalent-purpose-b20e66/contact-us.html?page=3"
Expand All @@ -339,8 +339,8 @@ These two HTML `span` elements have an [explicit role][] of link, same [accessib
<div>
<span style="text-align:center;">Contact us</span>
<span style="display:flex; justify-content:space-around;">
<img src="/test-assets/shared/chat.png" alt="Chat" style="width:50%;" />
<img src="/test-assets/shared/phone.png" alt="Phone" style="width:50%;" />
<img src="/test-assets/shared/chat.png" alt="Chat" style="max-width:50px;" />
<img src="/test-assets/shared/phone.png" alt="Phone" style="max-width:50px;" />
</span>
<span style="display:flex; justify-content:space-around;">
<span
Expand All @@ -367,7 +367,7 @@ These two SVG `a` elements have the same [accessible name][] and [context][progr
```html
<html lang="en">
<p>
<svg enable-background="new 0 0 264 120" viewBox="0 -20 264 140" xmlns="http://www.w3.org/2000/svg">
<svg enable-background="new 0 0 264 120" viewBox="0 -20 264 140" xmlns="http://www.w3.org/2000/svg" style="max-width:150px">
<text>Contact us</text>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text does appear very small on this example. Not really a problem (since this is not what the rule is about), but could still be improved.

<a
href="/test-assets/links-with-identical-names-serve-equivalent-purpose-b20e66/contact-us.html?page=1"
Expand Down Expand Up @@ -399,8 +399,8 @@ These two HTML `a` elements with the same [accessible name][] and [context][prog
<p>
<span style="text-align:center;">Contact us</span>
<span style="display:flex; justify-content:space-around;">
<img src="/test-assets/shared/chat.png" alt="Chat" style="width:50%;" />
<img src="/test-assets/shared/phone.png" alt="Phone" style="width:50%;" />
<img src="/test-assets/shared/chat.png" alt="Chat" style="max-width:50px;" />
<img src="/test-assets/shared/phone.png" alt="Phone" style="max-width:50px;" />
</span>
<span style="display:flex; justify-content:space-around;">
<a href="/test-assets/links-with-identical-names-serve-equivalent-purpose-b20e66/index.html">Contact Us</a>
Expand Down
Loading