-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW RULES] - Define author's responsibility when presentational roles conflict arises #2195
base: develop
Are you sure you want to change the base?
[NEW RULES] - Define author's responsibility when presentational roles conflict arises #2195
Conversation
allowed child element of another element with presentational role does not cause presentational roles conflicts
elements with ARIA presentational role do not have global states or properties
…a-presentational-role-no-global-states-properties-p8g918.md
|
||
## Applicability | ||
|
||
This rule applies to any [HTML or SVG element][] that is [included in the accessibility tree][], is an [allowed child element](https://w3c.github.io/aria/#mustContain) of another element with an [explicit semantic role][] of `none` or `presentation`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should link to editors drafts. These are not stable documents.
description: | | ||
This rule checks that allowed child element of another element with presentational role does not cause presentational roles conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This rule seems like a subset of our ARIA required context role
rule. It requires that elements that can't exist without a parent have that parent. The rule you propose is more focused, but it doesn't seem to cover anything that isn't also covered by the required context
rule. Or at least, I can't find anything that isn't.
Would a better solution be to add the one or both of the failed examples to required context
instead?
@@ -0,0 +1,175 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you should have more than one new rule in a PR.
@@ -0,0 +1,175 @@ | |||
--- | |||
id: p8g918 | |||
name: ARIA presentational role does not have global states or properties |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very sorry to do this a second time. I can tell you've put a lot of work into these, but this rule also seems like a duplicate to me. This time of Element marked as decorative is not exposed . Your version makes slightly different trade-offs about explicitly stating which props cause this problem, whereas the existing rule is vaguer about that. But then in being vaguer and just saying "not in the accessibility tree" its means it can handle changes to the ARIA spec like how aria-label is not a global attr if on role=none, but still fails for creating presentation conflict.
@@ -0,0 +1,139 @@ | |||
--- | |||
id: 18pg11 | |||
name: ARIA presentational role not focusable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above, the Element marked as decorative is not exposed rule covers this.
I think we can debate splitting the rule up into the two rules you propose. I'd personally lean towards leaving this as is, since the "not exposed" rule is already approved by AG, but if others feel there are good reasons to deprecate it in favor of this I'm open to that conversation.
New Rules:
Closes: #2193
Need for Call for Review:
This will require a 2 weeks Call for Review
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.When merging a PR:
How to Review And Approve