Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SC4-1-1-unique-id #256

Merged
merged 1 commit into from
Sep 27, 2018
Merged

Update SC4-1-1-unique-id #256

merged 1 commit into from
Sep 27, 2018

Conversation

annethyme
Copy link
Collaborator

Test case descriptions added + a note for the Applicability

Closes issue: #228

Guidance for the PR (pull request) creator

When creating PR:

  • Make sure you requesting to pull a issue/feature/bugfix branch (right side) to the master branch (left side).

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR
  • Add label to indicate if it's a Rule, Definition or Chore (more to the administrative side)
  • Add relevant project (e.g. "Q3 2018 Status") to PR
  • OPTIONAL: If you want anyone in particular to review your pull request, assign them as "Reviewers".
  • Close the issue that the PR resolves (and make sure the issue is referenced in the top of this comment)

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.

Test case descriptions added + a note for the Applicability
@annethyme annethyme added enhancement Rule Use this label for a new rule that does not exist already labels Sep 14, 2018
@annethyme annethyme self-assigned this Sep 14, 2018
@annethyme annethyme added this to Needs review in Q3 2018 Status via automation Sep 14, 2018
@WilcoFiers
Copy link
Member

@carlosapaduarte awaiting your review for this.

Q3 2018 Status automation moved this from Needs review to Reviewer approved Sep 27, 2018
Copy link
Member

@carlosapaduarte carlosapaduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the plural of id (ids) coherently throughout the test cases (in passed example 2 the plural is used, but not in failed examples 1 and 2)

@WilcoFiers WilcoFiers merged commit b6c578f into master Sep 27, 2018
Q3 2018 Status automation moved this from Reviewer approved to Done Sep 27, 2018
@WilcoFiers WilcoFiers deleted the update-SC4-1-1-unique-id branch September 27, 2018 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rule Use this label for a new rule that does not exist already
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants