Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rule "HTML has lang" with webpage definition #386

Merged
merged 1 commit into from Jan 9, 2019
Merged

fix: rule "HTML has lang" with webpage definition #386

merged 1 commit into from Jan 9, 2019

Conversation

jeeyyy
Copy link
Collaborator

@jeeyyy jeeyyy commented Jan 3, 2019

Update rule with link to webpage definition.

Closes issue: #363

@annethyme annethyme added Rule Use this label for a new rule that does not exist already enhancement labels Jan 7, 2019
@annethyme annethyme added this to Needs Review in Rules Progress Jan 7, 2019
@WilcoFiers
Copy link
Member

@annethyme @nitedog @carlosapaduarte could one of you please review this?

Rules Progress automation moved this from Needs Review to CFC (Reviewer Approved) Jan 9, 2019
@jeeyyy jeeyyy merged commit 3a253a1 into master Jan 9, 2019
Rules Progress automation moved this from CFC (Reviewer Approved) to Done Jan 9, 2019
@jeeyyy jeeyyy deleted the fix-html-has-lang branch January 9, 2019 15:29
@annethyme annethyme removed this from Published in Rules Progress Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

@ShadowBB ShadowBB ShadowBB approved these changes

@nitedog nitedog nitedog approved these changes

Assignees
No one assigned
Labels
Rule Use this label for a new rule that does not exist already
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jeeyyy @WilcoFiers @ShadowBB @nitedog @annethyme