New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some incorrect test cases #477
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* develop: chore: add unique id to all rules (#478)
carlosapaduarte
approved these changes
Apr 18, 2019
Minor spelling and formatting fixes. Also one of the examples had a wrong number.
ShadowBB
approved these changes
Apr 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Committed some minor formatting and spelling changes and approved.
* develop: fix: testcase for keyboard trap rule fix: atomic rule links chore: add manual reporting download links to rule (#492) chore: rename files and update associations (#489) chore: Add id to document-title-is-descriptive rule (#491) New rule: Document title is descriptive (#380) Update SC1-1-1-image-has-name.md (#468) chore: update test case names to be hash and not have outcome (#485) chore: update styles chore: fix styling and spacing on various resolutions chore: fix typo in rules chore: update dependencies
…thub.io into fix-test-cases * 'fix-test-cases' of github.com:kasperisager/act-rules.github.io: Minor spelling and formatting
WilcoFiers
approved these changes
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #473, fixes #474, and fixes #475.