Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "for each selected item" line to every rule #62

Merged
merged 2 commits into from
Feb 8, 2018
Merged

Add "for each selected item" line to every rule #62

merged 2 commits into from
Feb 8, 2018

Conversation

WilcoFiers
Copy link
Member

No description provided.

@WilcoFiers WilcoFiers mentioned this pull request Dec 6, 2017
Closed
carlosapaduarte
carlosapaduarte reviewed Jan 11, 2018
View reviewed changes
Copy link
Member

@carlosapaduarte carlosapaduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoud also update the rule template

@EmmaJP
Copy link
Collaborator

EmmaJP commented Jan 11, 2018

Thank you - good call Carlos

@EmmaJP EmmaJP mentioned this pull request Jan 11, 2018
Closed
@EmmaJP EmmaJP mentioned this pull request Jan 22, 2018
Closed
@WilcoFiers
Copy link
Member Author

Updated. @EmmaJP @carlosapaduarte Please update your review.

jribbens
jribbens approved these changes Feb 8, 2018
View reviewed changes
Copy link
Collaborator

@jribbens jribbens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@WilcoFiers WilcoFiers merged commit f202438 into master Feb 8, 2018
@WilcoFiers WilcoFiers deleted the foreach-selector branch February 8, 2018 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jribbens jribbens jribbens approved these changes

@carlosapaduarte carlosapaduarte carlosapaduarte approved these changes

@EmmaJP EmmaJP EmmaJP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@WilcoFiers @EmmaJP @jribbens @carlosapaduarte