Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead link to character #845

Merged
merged 2 commits into from Sep 10, 2019
Merged

Remove dead link to character #845

merged 2 commits into from Sep 10, 2019

Conversation

Jym77
Copy link
Collaborator

@Jym77 Jym77 commented Aug 27, 2019

<< Describe the changes >>
"Fixing" a dead link (to glossary) by removing it.

Closes issue(s):


Pull Request Etiquette

When creating PR:

  • Make sure you requesting to pull a branch (right side) to the develop branch (left side).

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Close the issue that the PR resolves (and make sure the issue is referenced in the top of this comment)
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.

@Jym77 Jym77 self-assigned this Aug 27, 2019
@Jym77 Jym77 added Definition Rule Update Use this label for an existing rule that is being updated labels Aug 27, 2019
@jeeyyy
Copy link
Collaborator

jeeyyy commented Sep 10, 2019

May be create an issue for why this was not caught in a test case.

@Jym77
Copy link
Collaborator Author

Jym77 commented Sep 10, 2019

Issue was #829 with PR in place #857

@Jym77 Jym77 merged commit ae4612a into develop Sep 10, 2019
@Jym77 Jym77 deleted the remove-dead-link-to-character branch September 10, 2019 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Definition reviewers wanted Rule Update Use this label for an existing rule that is being updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants