Address PR Comments

acteng · Feb 23, 2024 · ad12d4c · ad12d4c
1 parent 60e3f68
commit ad12d4c
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 11 deletions.
diff --git a/assets/train.png b/assets/train.png
diff --git a/src/lib/browse/colors.ts b/src/lib/browse/colors.ts
@@ -13,15 +13,13 @@ export const colors = {
   mrn: "#006478",
   national_cycle_network: "#640078",
   sports_spaces: "#013220",
-  railway_stations: "#A52A2A",
   parliamentary_constituencies: "#006E59",
   wards: "purple",
   combined_authorities: "cyan",
   local_authority_districts: "orange",
   local_planning_authorities: "red",
   bus_route_with_lane: "#9362BA",
   bus_route_without_lane: "#C2A6D8",
-  cycle_parking: "black",
   trams: "black",
   signalized_crossing: "green",
   other_crossing: "black",

diff --git a/src/lib/browse/layers/SequentialLegend.svelte b/src/lib/browse/layers/SequentialLegend.svelte
@@ -3,7 +3,7 @@
   export let limits: any[];
 </script>
 
-<div style="display: flex; padding-left:15px; padding-right:15px;">
+<div style="display: flex">
   {#each colorScale as color}
     <span style="background: {color}; width: 100%; border: 1px solid black;">
       &nbsp;
@@ -12,6 +12,6 @@
 </div>
 <div style="display: flex; justify-content: space-between;">
   {#each limits as limit}
-    <span style="flex-grow: 1; flex-shrink: 1; text-align:center;">{limit}</span>
+    <span>{limit}</span>
   {/each}
 </div>
diff --git a/src/lib/browse/layers/points/CycleParking.svelte b/src/lib/browse/layers/points/CycleParking.svelte
@@ -5,10 +5,10 @@
     Popup,
     publicResourceBaseUrl,
   } from "lib/common";
-  import cycleParking from "../../../../../assets/bicycle_parking.png?url";
   import { Checkbox } from "lib/govuk";
   import { layerId } from "lib/maplibre";
   import { SymbolLayer, VectorTileSource } from "svelte-maplibre";
+  import cycleParking from "../../../../../assets/bicycle_parking.png?url";
   import OsmLicense from "../OsmLicense.svelte";
 
   let name = "cycle_parking";
@@ -17,7 +17,7 @@
 </script>
 
 <Checkbox bind:checked={show}>
-  <img src={cycleParking} />
+  <img src={cycleParking} alt="a logo representing cycle parking" />
   Cycle parking
   <span slot="right">
     <HelpButton>
@@ -30,7 +30,9 @@
         access, and whether it's covered are not shown.
       </p>
       <p>
-        Icon from <a href="https://github.com/gravitystorm/openstreetmap-carto?tab=License-1-ov-file#readme">OpenStreetMap Carto</a>
+        Icon from <a href="https://github.com/gravitystorm/openstreetmap-carto">
+          OpenStreetMap Carto
+        </a>
       </p>
       <OsmLicense />
     </HelpButton>

diff --git a/src/lib/browse/layers/points/RailwayStations.svelte b/src/lib/browse/layers/points/RailwayStations.svelte
@@ -17,7 +17,7 @@
 </script>
 
 <Checkbox bind:checked={show}>
-  <img src={railwayStation} />
+  <img src={railwayStation} alt="A logo representing a train" />
   Railway Stations
   <span slot="right">
     <HelpButton>
@@ -29,9 +29,7 @@
         </ExternalLink> data from OpenStreetMap (as of 9 August 2023).
       </p>
       <p>
-        Icon from <a
-          href="https://iconduck.com/sets/font-awesome-icons"
-        >
+        Icon from <a href="https://iconduck.com/sets/font-awesome-icons">
           Font Awesome Icons
         </a>
       </p>