Move govuk components to another repo #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabreegster
commented
Feb 21, 2024
| @@ -47,6 +47,7 @@ | |||
| "@turf/nearest-point-on-line": "^6.5.0", | |||
| "@turf/random": "^6.5.0", | |||
| "govuk-frontend": "^5.1.0", | |||
| "govuk-svelte": "github:acteng/govuk-svelte", | |||
There was a problem hiding this comment.
We could publish to NPM, but it might encourage other people to take a dependency on them, despite the warnings in the README. For the moment, I think the git dependency is simpler. When we need to update the components, we commit in the other repo, then npm i govuk-svelte here to update the pinning in package-lock.json.
I can publish to NPM if you prefer though
dabreegster
force-pushed
the
refactor_govuk
branch
from
199fd55
to
8fa17f2
Compare
|
Rebased. The test failure looks like a flake to me, but will see what the rerun looks like |
Pete-Y-CS
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved all the common govuk Svelte components to https://github.com/acteng/govuk-svelte, since we'll want to use these in more projects. No behavioral change here.