Upgrade to maplibre 4 #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabreegster
commented
Feb 28, 2024
| } | ||
| }, | ||
| ); | ||
| async function clickCluster(e: CustomEvent<LayerClickInfo>) { |
There was a problem hiding this comment.
maplibre went through a major internal refactor to use promises instead of callbacks. Nicer APIs as a result :)
There was a problem hiding this comment.
Is this the only place where it changes stuff for us? Wild that this refactor is happening now but looks good!
There was a problem hiding this comment.
TS doesn't lie (much) :) I don't think the API changes were that bad anyway: dimfeld/svelte-maplibre#128
There was a problem hiding this comment.
I mean I guess it must be but it's surprising
Pete-Y-CS
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was waiting on a geocoder dependency to get support, but now we can do this. https://github.com/maplibre/maplibre-gl-js/blob/main/CHANGELOG.md lots of changes, most invisibly handled in svelte-maplibre already