Fix disapparing images when switching basemaps #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabreegster
commented
Mar 14, 2024
| @@ -81,7 +81,7 @@ | |||
| }} | |||
| > | |||
| <CircleLayer | |||
| {...layerId(`${source}-clusters`)} | |||
| {...layerId(`criticals-clusters`)} | |||
There was a problem hiding this comment.
Indirections make it hard to grep code and find where stuff is used
|
|
||
| "draw-street-view", |
There was a problem hiding this comment.
This was unused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits here. The first is just refactor, trying to be more precise about the combinatorial explosion of basemap and overlay layers we have. And the second fixes the problem reported recently. Enable cycle parking (which uses an extra image we load), switch basemaps -- now the symbol still works. We just needed https://github.com/dimfeld/svelte-maplibre/blob/master/CHANGELOG.md#082.
Note I still think there might be some z-order oddness when changing basemaps. We decide the layer order when the layers are first created, which'll depend on the basemap layer names that exist at that point. If the user switches basemaps, I don't think we run this calculation again. Harder one to think about for the future.