Use gzipped scheme data #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pete-Y-CS
approved these changes
Apr 3, 2024
|
I'll be offline until about 2, please do merge as soon as dev env is ready
for it
…On Wed, Apr 3, 2024, 10:52 AM Pete-Y-CS ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#494 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMWLF4WJBIBDWDYPMBWAA3Y3PGNTAVCNFSM6AAAAABFU6II6CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNZWGIZTCNRQGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Pete-Y-CS
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As fate would have it, we're forced to look at #493 immediately, because we're now over the 32MB app engine response limit. If we gzip that file, it's down to about 7MB and loads much faster on slow connections anyway!
Do
gzip --keep all_schemes_output.geojsonafter running the combine script, and upload that to the sameprivate_layers/v1/folder. Please test in the dev environment first, deploy this PR manually (backend/README has instructions), make sure everthing works end-to-end, then push to test env