Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show LCWIP fields in browse popups #498

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

dabreegster
Copy link
Contributor

A start towards #493. The extra LCWIP fields are invisible now; this at least starts showing them in per-feature popups. Also added bolding to values, to try and be consistent with the style for other browse popups.

I don't know if this way of presenting information is useful, but it seems better than not showing anything

Copy link
Contributor

@Pete-Y-CS Pete-Y-CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. I wonder if it will be confusing as is if there are cases where the feature and the scheme have budget and/or timeline data

@dabreegster
Copy link
Contributor Author

Agreed it's confusing. Right now we have two sections of the popup. We could consolidate and have a way to indicate if that field is per-feature or per-scheme. Need to know how people want to use this.

@dabreegster dabreegster merged commit a737d77 into main Apr 8, 2024
2 checks passed
@dabreegster dabreegster deleted the show_pipeline_in_browse branch April 8, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants