Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calendar event fixes (new) #1040

Merged
merged 6 commits into from Oct 13, 2023
Merged

calendar event fixes (new) #1040

merged 6 commits into from Oct 13, 2023

Conversation

gtalha07
Copy link
Contributor

@gtalha07 gtalha07 commented Oct 10, 2023 •
edited

Issue opened after merge: #1033
Currently missing API: Upcoming and Past event for spaces.

@gtalha07 gtalha07 marked this pull request as ready for review October 10, 2023 23:29
gnunicorn
gnunicorn approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@gnunicorn gnunicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you!

This screams for a nice message in .changes to inform the users about this awesome new feature set around the events. Please add some. Other than that just some minor remarks at your disgression.

app/lib/features/events/pages/event_page.dart Outdated Show resolved Hide resolved
app/lib/features/events/pages/event_page.dart Outdated Show resolved Hide resolved
app/lib/features/events/pages/event_page.dart Outdated Show resolved Hide resolved
app/lib/features/events/pages/event_page.dart Outdated Show resolved Hide resolved
app/lib/features/events/providers/event_providers.dart Show resolved Hide resolved
app/lib/features/events/sheets/edit_event_sheet.dart Outdated Show resolved Hide resolved
app/lib/features/events/sheets/edit_event_sheet.dart Outdated Show resolved Hide resolved
app/lib/features/events/sheets/edit_event_sheet.dart Outdated Show resolved Hide resolved
app/lib/features/events/sheets/edit_event_sheet.dart Outdated Show resolved Hide resolved
app/lib/features/space/widgets/events_card.dart Outdated Show resolved Hide resolved
@gtalha07 gtalha07 merged commit d9b7c67 into acterglobal:main Oct 13, 2023
15 of 16 checks passed
@gtalha07 gtalha07 mentioned this pull request Oct 13, 2023
Closed
9 tasks
@gtalha07 gtalha07 deleted the issue800_calendar-events branch November 13, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnunicorn gnunicorn Awaiting requested review from gnunicorn

Assignees
No one assigned
Labels
None yet
Projects
Product
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gtalha07 @gnunicorn