Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide bottom bar if on-screen keyboard is visible. Dismiss keyboard on tap #1058

Merged
merged 4 commits into from Oct 18, 2023
Merged

Hide bottom bar if on-screen keyboard is visible. Dismiss keyboard on tap #1058

merged 4 commits into from Oct 18, 2023

Conversation

gnunicorn
Copy link
Contributor

@gnunicorn gnunicorn commented Oct 18, 2023 •
edited

@gnunicorn gnunicorn added the smooth UX minor UI/UX problems and tasks label Oct 18, 2023
@gnunicorn gnunicorn marked this pull request as ready for review October 18, 2023 10:20
gtalha07
gtalha07 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@gtalha07 gtalha07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gnunicorn gnunicorn merged commit 0eb634f into main Oct 18, 2023
18 of 19 checks passed
@gnunicorn gnunicorn deleted the ben-dismiss-bottombar-and-keyboard branch October 18, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtalha07 gtalha07 gtalha07 approved these changes

Assignees
No one assigned
Labels
smooth UX minor UI/UX problems and tasks
Projects
Product
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide menu bottom menu (on mobile) when in the chat and keyboard is showing
2 participants
@gnunicorn @gtalha07