Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create chat flow implementation #1060

Merged
merged 20 commits into from Oct 26, 2023

Conversation

gtalha07
Copy link
Contributor

@gtalha07 gtalha07 commented Oct 18, 2023

Description:
This PR attempts to revise the current chat creation flow with more flexibility and bringing out adaptive UI aspect with the ease of creating default chat (as been currently) and in addition, ability to create DM, Group DM by selecting users.

  • fixes from Improve chat #862 and direct follow up implementation of Implement create chat flow #853.
  • This removes the need of using side sheet as interface and routing for it and instead will show modal based on platform .i.e. bottom sheet for mobile, dialog for larger screen sizes and desktop.
  • Also the creation loading processes has been modified to use EasyLoading, making it much simpler to start a chat.

Next Steps: The next follow up PR's for this will be adding suggestions list and adding invitations for creating a default room.

@gtalha07 gtalha07 marked this pull request as ready for review October 25, 2023 13:44
@gtalha07
Copy link
Contributor Author

Create Chat Dialog (Desktop/Larger Screens):
Screenshot 2023-10-25 at 6 53 58 PM

Create Chat Dialog (Space):
Screenshot 2023-10-25 at 6 54 56 PM

Start Group DM:
Screenshot 2023-10-25 at 6 56 16 PM

Start/Go DM:
Screenshot 2023-10-25 at 6 56 36 PM

Mobile Version:
Screenshot 2023-10-25 at 7 02 27 PM

Screenshot 2023-10-25 at 7 03 02 PM Screenshot 2023-10-25 at 7 03 32 PM

Copy link
Contributor

@gnunicorn gnunicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks @gtalha07 .

Just two things: one around the BuildContext being used in some weird way in two occasions; and the other to keep a link-able route in the mix and do the determination which widget to use in its route-controller (rather than have the caller figure that out).

app/ios/Runner.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
app/lib/common/utils/routes.dart Show resolved Hide resolved
app/lib/features/chat/widgets/rooms_list.dart Outdated Show resolved Hide resolved
app/lib/features/chat/widgets/rooms_list.dart Outdated Show resolved Hide resolved
app/lib/features/chat/widgets/rooms_list.dart Outdated Show resolved Hide resolved
app/lib/features/chat/widgets/create_chat.dart Outdated Show resolved Hide resolved
app/lib/features/chat/widgets/create_chat.dart Outdated Show resolved Hide resolved
app/lib/features/chat/widgets/create_chat.dart Outdated Show resolved Hide resolved
app/lib/features/chat/widgets/create_chat.dart Outdated Show resolved Hide resolved
app/lib/features/chat/widgets/create_chat.dart Outdated Show resolved Hide resolved
Copy link
Contributor

@gnunicorn gnunicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just that small thing left...

app/lib/features/chat/widgets/create_chat.dart Outdated Show resolved Hide resolved
app/lib/router/router.dart Outdated Show resolved Hide resolved
@gtalha07 gtalha07 merged commit e260f8e into acterglobal:main Oct 26, 2023
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants