Update matrix-sdk & reaplce sled with sqlite #631
Conversation
| /// whether this an acter space | ||
| fn is_acter_space() -> Future<bool>; | ||
|
|
There was a problem hiding this comment.
I removed it because Space::isActerSpace() is not used on flutter side.
native/acter/src/api/auth.rs
Outdated
| Ok(c) | ||
| }) | ||
| .await? | ||
| let client = config |
There was a problem hiding this comment.
how come this doesn't need the RUNTIME.spawn anymore? That sounds dubious.
There was a problem hiding this comment.
login_with_token() calls new_client_config() and login_with_token_under_config().
Because login_with_token_under_config() is wrapped by RUNTIME.spawn() now, I couldn't wrap login_with_token(), caller of login_with_token_under_config() by RUNTIME.spawn().
As we know, new_client_config() contains async api of matrix and it must be spawned in tokio task.
So I wrapped new_client_config() by RUNTIME.spawn().
native/acter/src/api/auth.rs
Outdated
| Ok(c) | ||
| }) | ||
| .await? | ||
| let client = config.build().await.context("buidling failed in client")?; |
There was a problem hiding this comment.
this, too, doesn't need a RUNTIME.spawn anymore?
There was a problem hiding this comment.
Same answer as above.
bitfriend
changed the title
| @@ -25,7 +25,7 @@ jobs: | |||
| - uses: Swatinem/rust-cache@v1 | |||
| - uses: nttld/setup-ndk@v1 | |||
| with: | |||
| ndk-version: r23c | |||
| ndk-version: r22b | |||
There was a problem hiding this comment.
downgrades like this really should be mentioned, and explained in the PR description. This is not what someone would expect to happen in this PR coming from the title and description!
Update matrix-sdk to latest with replacing sled with sqlite