New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix newline character in doc of field #177

Merged

actgardner merged 1 commit into actgardner:master from cmouli84:feature/fix-newline-doc-in-field

Feb 3, 2022

Contributor

cmouli84 commented Feb 3, 2022 •

edited

Loading

Context

As part of v7.3.1, fix was done to generate Go code for enums, fields and records with newlines in the doc field
Seems the change got accidentally reverted in v8.0.0 in the file schema/field.go

Changes

Added the same fix again in v10/schema/field.go
Updated test schema v10/test/primitive/schema.avsc and ran ./v10/test.sh
Ran go mod tidy


          Fix newline character in doc of field

dea3241

Owner

actgardner commented Feb 3, 2022

Thanks for the PR @cmouli84! Looks good :)

actgardner merged commit b77063f into actgardner:master

cmouli84 deleted the feature/fix-newline-doc-in-field branch

February 3, 2022 04:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment