New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

empty config object merge fix #1284

Closed

shookie wants to merge 1 commit into actionhero:master from shookie:empty_config_merge

Contributor

shookie commented Jan 14, 2019

Fix to #1283.


          empty config object merge fix

3e74cbd

Member

evantahler commented Jan 19, 2019

The test suite is failing with your changes. I've added an additional test that explains why in 940c2bc

Basically, this is used for setting up chat rooms, so all the chat-related tests are failing.

Member

evantahler commented Jan 19, 2019

Closing, as #1283 was determined not to be a bug.

evantahler closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment