New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add custom http status code with error object #1334
Merged
evantahler
merged 4 commits into
actionhero:master
from
piyushagwl007:feat-add_custom_error_response_code
Sep 10, 2019
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
35f2028
feat: add custom http status code with error object
piyushagwl007 67bdf2d
move adding custom error logic to web server file
piyushagwl007 3de90d0
Merge branch 'master' into feat-add_custom_error_response_code
evantahler f790e2e
feat-add test to check response code attached is valid
piyushagwl007 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been out of touch with JS for a bit. What does
!!data.params.randomkey
do?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
randomKey
is not passed in the request, so it will beundefined
, so!undefined
will be true and doing!!undefined
will become false which means that the variable is not sent.If
randomKey
is set it will return true for!randomKey
and doing!!randomKey
will return true.I wanted to not do this kind of thing as I know it seems confusing, but I was unable to find any kind of
isEmpty
sort-of Util but was unable to find, so used this type of thing.Should I remove this and create an
isEmpty
sort-of Util and go ahead with that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the typical convention is to use
const hasRandomKey = data.params && data.params.randomKey
. Has that changed recently?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are absolutely right, doing
const hasRandomKey = data.params && data.params.randomKey
would produce the same result, but thenhasRandomKey
will contain the value ofdata.params.randomKey
not aboolean
, I thought that since the variable name ishasRandomKey
it represents aboolean
, plus that makes easy to read the if condition rather than predicting what it will do. Is this a good way to go?