Fix TaskData Typescript type

[witem]

TaskData defined as object with params:

actionhero/src/classes/task.ts

Lines 92 to 96 in ddc4821

	export interface TaskData {
	params: {
	[key: string]: any;
	};
	}

But when some task enqueues it not adds params cover, simply send inputs as arg:

actionhero/src/modules/task.ts

Lines 56 to 62 in ddc4821

	export async function enqueue(
	taskName: string,
	inputs: { [key: string]: any },
	queue: string = api.tasks.tasks[taskName].queue
	) {
	await validateInput(taskName, inputs);
	return api.resque.queue.enqueue(queue, taskName, [inputs]);

[evantahler]

Thank you!

How would you feel about also using the TaskData type in modules/task (replacing { [key: string]: any }) to indicate that the same data will be returned back to the task when run?

ie:

actionhero/src/modules/task.ts

Line 58 in ddc4821

inputs: { [key: string]: any },

actionhero/src/modules/task.ts

Line 77 in ddc4821

inputs: { [key: string]: any },

actionhero/src/modules/task.ts

Line 97 in ddc4821

inputs: { [key: string]: any },

actionhero/src/modules/task.ts

Line 117 in ddc4821

args?: { [key: string]: any },

actionhero/src/modules/task.ts

Line 135 in ddc4821

inputs?: { [key: string]: any }

actionhero/src/modules/task.ts

Line 152 in ddc4821

inputs: { [key: string]: any }

[witem]

@evantahler I think its good idea. I change it.
But maybe also need change argument name from inputs to taskDatanot to be confused with inputs in task describe

[evantahler]

That works for me! Feel free to change the name if you want!

[witem]

I change arguments naming, check please. Thanks!

[evantahler]

Ah! I should have been more clear, I'm sorry - Since we use the word inputs already in our examples and docs, I think we should keep that word. I would suggest changing TaskData to TaskInputs in the exported interface.

[witem]

Ok, I update

[evantahler]

Awesome! Thanks!