Validate that Action inputs do not use reserved params #1521
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An expansion on #1520
This PR also moves calling
api.params.buildPostVariables()
to the action initializer so can loadapi.params.globalSafeParams
earlier in the boot process.Original Description:
issue:
My colleague meets the issue, he adds an "action" key in an action input...
but "action" is a keyword, apiVersion also.
can we have a checker to avoid it? even in build time or runtime.
Example
problem:
I was tried to add
class/action.ts
validate usingapi.params.globalSafeParams
ofinitializers/params.ts
But
action.validate
called byinitializers/action.ts
and its load priority is 410 andparams.ts
is 420.So
api.parmas
is undefined whenaction.validate
is call.I was tried to change load priority, but I found
params.ts
needapi.actions
two... It's a deadlock, have any idea?