Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brings back api.exceptionHandlers.action for logging action errors with third-party error reporters #1558

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

evantahler
Copy link
Member

@evantahler evantahler commented Aug 14, 2020

Returns api.exceptionHandlers.action so that errors from actions can be passed to third-party error reporters. IE:

api.exceptionHandlers.reporters.push((error: Error) => {
  Sentry.captureException(error);
});

The actionProcessor still handles logging the action.

Related to https://github.com/actionhero/ah-sentry-plugin

@evantahler evantahler added bug Something isn't working enhancement New feature or request labels Aug 14, 2020
@evantahler
Copy link
Member Author

This was erroneously removed in #1505, as it does more than just handle writing to the console.

@evantahler evantahler merged commit 563107d into master Aug 14, 2020
@evantahler evantahler deleted the action-errror-reporting branch August 14, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant