-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds an option to override default error log formatting #1570
Adds an option to override default error log formatting #1570
Conversation
Hi, I'm not sure, what could've caused the failing test after the merge. I'd appreciate any help. |
Looks like it was just a timeout in the Browser integration test:
I'll run them again! In the future, if you want to run it again yourself, just push another empty commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a great addition!
I'd suggest adding a little more safety around your call to config.errors.serializers.actionProcessor
. As written, this would be a breaking change to Actionhero, as it won't work without adding the new method to config/errors. Is there a (possibly simplified) default behavior you can add if config.errors.serializers.actionProcessor
doesn't exist?
But it also breaks old log format. Maybe need to move default serializer to |
Great points. Thanks. I've moved the default logic back to actionProcessor and you use it as a fallback to the serializer. What do you think? |
Awesome work! |
Move action error logline formatting logic from actionProcessor to error serializers to make it possible to override default action error logging, as previously discussed in #1561