Update Dockerfile base image to node:alpine #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pine. Signed-off-by: Greg Coonrod <greg.coonrod@gmail.com>
… include volumes for node_modules and dist. Also ensuring that the compose config for the local build options mirrors the config for using the published actionhero image. Signed-off-by: Greg Coonrod <greg.coonrod@gmail.com>
evantahler
requested changes
Sep 4, 2020
|
Thanks! |
evantahler
approved these changes
Sep 4, 2020
|
And the build starts! https://hub.docker.com/repository/docker/actionhero/actionhero |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will replace #1580 and removes the huge number of merge commits.