Rebuild Config on Server Restart #2076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evantahler
requested changes
Jan 6, 2022
There was a problem hiding this comment.
This is probably important to test.
Here's a potential path forward:
- set a config with an ENV (like PORT=12345)
- startup the test like normal
actionhero/__tests__/actions/cacheTest.ts
Lines 5 to 7 in 80895af
- test that the config is what you expect (config.web.port === 12345)
- change the ENV in the test
- assert that the config is the old value
- reboot the server (process.restart)
- assert that the config is the new value
evantahler
approved these changes
Jan 10, 2022
Comment on lines
+12
to
+18
| it("updates config on 'restart'", () => { | ||
| const port = "2020"; | ||
| process.env.PORT = port; | ||
| expect(config.web.port).not.toBe(port); | ||
| rebuildConfig(); | ||
| expect(config.web.port).toBe(port); | ||
| }); |
Comment on lines
+234
to
+242
| export let config = buildConfig(); | ||
| export const rebuildConfig = () => { | ||
| recalculateEnv(); | ||
| recalculateActionheroVersion(); | ||
| recalcuateId(); | ||
| recalculateProjectRoot(); | ||
| recalculateIsTypescript(); | ||
| config = buildConfig(); | ||
| }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding rebuild config method. Calling rebuild config method on server restart.