fix ParamsFrom type inference
#2108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,7 +22,7 @@ export class HelloCliTest extends CLI { | |||
| }, | |||
| }, | |||
| countries: { | |||
| variadic: true as const, | |||
| variadic: true as true, | |||
There was a problem hiding this comment.
I was able to consolidate the Params type, but as const or as true is still required since typescript can't narrow the type well enough itself.
There was a problem hiding this comment.
What we could also do is make a function called VariadicType that just takes an Input and says what our type is doing. Then we could avoid the as const part.
|
Oh, this is a nice improvement to |
evantahler
approved these changes
Jan 29, 2022
pedroslopez
changed the title
CLIParamsFrom to its own typeParamsFrom type inference
|
|
||
| type Variadic = { variadic: true }; | ||
|
|
||
| export type ParamsFrom<A extends Action | Task | CLI> = { |
There was a problem hiding this comment.
It might be worth putting Action | Task | CLI into a single type, but I don't think this is likely to change.
evantahler
approved these changes
Jan 31, 2022
|
Releasing a new version now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, TypeScript has trouble inferring types properly when using
A extends CLIas a conditional.You can play around with this example here eee6e8d
Separating out ParamsFrom for the CLI to it's own type lets you explicitly use it, though I'd still like to find a solution that keeps things in a single
ParamsFromthat works for both if possible, hence the draft PR. Pushed here for visibility.