Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved ParamsFrom logic for required fields #2125

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Improved ParamsFrom logic for required fields #2125

merged 1 commit into from
Feb 16, 2022

Conversation

krishnaglick
Copy link
Collaborator

Requires we do true as true or true as const but it works if you do!

evantahler
evantahler approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the work you've done to enhance the ParamsFrom<> utility! Let's get this merged in. That said, I'm curious to see how many people are going to type their booleans...

@evantahler evantahler merged commit 44e17a9 into main Feb 16, 2022
@evantahler evantahler deleted the ParamsFrom-better-required-logic branch February 16, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evantahler evantahler evantahler approved these changes

@pedroslopez pedroslopez Awaiting requested review from pedroslopez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krishnaglick @evantahler