Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix glob problems with path's in windows, safeGlobSync implemented. #2278

Merged
merged 3 commits into from Sep 6, 2022
Merged

Fix glob problems with path's in windows, safeGlobSync implemented. #2278

merged 3 commits into from Sep 6, 2022

Conversation

YamCrack
Copy link
Contributor

@YamCrack YamCrack commented Sep 2, 2022 •
edited by evantahler

Closes #2275

@evantahler
Copy link
Member

Please update the title to describe what this work does and provide a description of this work

evantahler
evantahler reviewed Sep 2, 2022
View reviewed changes
Copy link
Member

@evantahler evantahler left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!
Please add a test asserting that all the files you expect in a directory are returned.

@YamCrack
Copy link
Contributor Author

YamCrack commented Sep 3, 2022 •
edited

image
I have written this test, do you think it is enough?

test: ✅ added test for safeGlobSync
2985400 
added test to compare results between glob and new function safeGlobSync
@YamCrack YamCrack changed the title Merge branch 'main' of https://github.com/actionhero/actionhero Fix glob problems with path's in windows, safeGlobSync implemented. Sep 6, 2022
@evantahler
Copy link
Member

evantahler commented Sep 6, 2022 •
edited

I have written this test, do you think it is enough?

Si! Es perfecto.

evantahler
evantahler approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@evantahler evantahler merged commit 1552c8e into actionhero:main Sep 6, 2022
@evantahler
Copy link
Member

Released in https://github.com/actionhero/actionhero/releases/tag/v28.1.12

@evantahler evantahler mentioned this pull request Sep 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evantahler evantahler evantahler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: actionhero generate does nothing on windows
2 participants
@YamCrack @evantahler