New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pushing a number of resque logs deeper #612
pushing a number of resque logs deeper #612
Conversation
I'm personally of the opinion that starging/stopping workers should be of the comments welcome |
When using multiworkers i was seeing workers stopped and started every second. Which really cluttered up the logs. What is the rationale for having those events at the info level? |
The rationale was in production the lowest log level you probably might use would be |
Info seems like the right choice to me too. It's certainly not higher than that. I guess you could make a case for debug but I'd expect to see it in info. |
Any thoughts on making the worker log levels controllable? |
lets see what a PR for that would look like @gcoonrod! Might make sense depending on how much cruft that adds to the config file |
@evantahler, I added an attribute to the tasks config and set some of the node-resque messages to use that attribute to determine their logging level. I only applied that option to the messages that have been bugging me. Are there other messages that this option could/should be applied to? |
@@ -2,16 +2,18 @@ exports.default = { | |||
tasks: function(api){ | |||
return { | |||
// Should this node run a scheduler to promote delayed tasks? | |||
scheduler: false, | |||
scheduler: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't commit this
@evantahler Any further comments or suggestions? |
@@ -5,6 +5,8 @@ exports.default = { | |||
scheduler: false, | |||
// what queues should the taskProcessors work? | |||
queues: ['*'], | |||
// Verbosity of task logging | |||
verbose: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that I like having a log option outside of the logging config file.
Perhaps the answer is a hash with each event => log level?
{start: "debug", poll: "trace"}
Lets merge it in for now, although I do expect some future changes. |
Thanks! |
pushing a number of resque logs deeper
Trying to reduce the verbosity of resque logging.