Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pushing a number of resque logs deeper #612

Merged
merged 3 commits into from Mar 16, 2015

Conversation

gcoonrod
Copy link
Member

@gcoonrod gcoonrod commented Mar 6, 2015

Trying to reduce the verbosity of resque logging.

@evantahler
Copy link
Member

I'm personally of the opinion that starging/stopping workers should be of the info level, but lets here what others think

comments welcome

@gcoonrod
Copy link
Member Author

gcoonrod commented Mar 6, 2015

When using multiworkers i was seeing workers stopped and started every second. Which really cluttered up the logs. What is the rationale for having those events at the info level?

@evantahler
Copy link
Member

The rationale was in production the lowest log level you probably might use would be "info". On production you are likely to be using a log aggression tool like Splunk, Sumologic, etc, and you probably want to know how many of your workers are running at any time. You can then scan for the latest log of this type to see how many are up and running.

@neilstuartcraig
Copy link
Contributor

Info seems like the right choice to me too. It's certainly not higher than that. I guess you could make a case for debug but I'd expect to see it in info.
For reference, you could check what apps like nginx etc do. Not saying they're becessarily right but could be validation.

@gcoonrod
Copy link
Member Author

gcoonrod commented Mar 6, 2015

Any thoughts on making the worker log levels controllable?

@evantahler
Copy link
Member

lets see what a PR for that would look like @gcoonrod! Might make sense depending on how much cruft that adds to the config file

@gcoonrod
Copy link
Member Author

gcoonrod commented Mar 6, 2015

@evantahler, I added an attribute to the tasks config and set some of the node-resque messages to use that attribute to determine their logging level. I only applied that option to the messages that have been bugging me.

Are there other messages that this option could/should be applied to?

@@ -2,16 +2,18 @@ exports.default = {
tasks: function(api){
return {
// Should this node run a scheduler to promote delayed tasks?
scheduler: false,
scheduler: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't commit this

@gcoonrod
Copy link
Member Author

@evantahler Any further comments or suggestions?

@@ -5,6 +5,8 @@ exports.default = {
scheduler: false,
// what queues should the taskProcessors work?
queues: ['*'],
// Verbosity of task logging
verbose: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that I like having a log option outside of the logging config file.

Perhaps the answer is a hash with each event => log level?

{start: "debug", poll: "trace"}

@evantahler
Copy link
Member

Lets merge it in for now, although I do expect some future changes.

@evantahler
Copy link
Member

Thanks!

evantahler added a commit that referenced this pull request Mar 16, 2015
pushing a number of resque logs deeper
@evantahler evantahler merged commit e5720b9 into actionhero:master Mar 16, 2015
@gcoonrod gcoonrod deleted the enhancement/traceLogging branch March 16, 2015 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants