Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration for file paths (fixes #722) #796

Merged
merged 8 commits into from
May 10, 2024
Merged

Add configuration for file paths (fixes #722) #796

merged 8 commits into from
May 10, 2024

Conversation

samuel-jimenez
Copy link
Contributor

Fixes #722

actionless
actionless reviewed May 9, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@actionless actionless changed the title Add configuration for file paths Add configuration for file paths (fixes #722) May 9, 2024
actionless
actionless reviewed May 9, 2024
View reviewed changes
README.md Show resolved Hide resolved
@samuel-jimenez
Copy link
Contributor Author

Documentation updated

actionless
actionless reviewed May 9, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@actionless
Copy link
Owner

also you need to default cli flags to the value from the config,
see implementation for --preserve-env as an example: https://github.com/actionless/pikaur/blob/master/pikaur/args.py#L256-L260

@samuel-jimenez
Copy link
Contributor Author

Changes made.

actionless
actionless reviewed May 9, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@actionless actionless merged commit 1f67c5c into actionless:master May 10, 2024
1 check failed
@actionless
Copy link
Owner

thanks for your first contribution! 🎉

@actionless actionless mentioned this pull request May 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@actionless actionless actionless left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make dirs configurable via pikaur.conf
2 participants
@samuel-jimenez @actionless