Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close channel after getting a response #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

2m
Copy link

@2m 2m commented Aug 22, 2020

This fixes the following errors from the logs:

Make sure to call shutdown()/shutdownNow() and wait until awaitTermination() returns true.

This fix was originally mentioned in #30 (comment)

I have also published this change to my bintray repository so I can use this fix in https://github.com/actions-on-google/smart-home-java

If anyone else is interested, you can also use it by adding the following to the gradle build:

repositories {
  maven {
    url 'http://dl.bintray.com/2m/maven'
  }
}

dependencies {
  implementation 'com.google.actions:actions-on-google:1.8.0-2m'
}

This fixes the following errors from the logs:

```
Make sure to call shutdown()/shutdownNow() and wait until awaitTermination() returns true.
```

This fix was originally mentioned in actions-on-google#30 (comment)
@Fleker
Copy link
Member

Fleker commented Aug 24, 2020

@proppy can you evaluate this?

@proppy
Copy link
Contributor

proppy commented Aug 31, 2020

As mentioned in #30 (comment), I think we should consider tying the lifecycle of the channel to SmartHomeApp.

Should we split the fix to CONTRIBUTING.md in a separate pull request?

@2m
Copy link
Author

2m commented Aug 31, 2020

Sounds good. I will split changes to CONTRIBUTING.md to a separate PR and also will rework this PR so the lifecycle of the channel is tied to SmartHomeApp.

@proppy
Copy link
Contributor

proppy commented Aug 31, 2020

@2m just a related note that we are also considering removing this homegraph wrapper altogether in favor of having developer depends directly on the generated homegraph bindings: https://github.com/googleapis/google-api-java-client-services/tree/master/clients/google-api-services-homegraph/v1

I'd be curious to hear your thoughts.

@EgHubs
Copy link

EgHubs commented Apr 27, 2022

looks like the link of bintray is unavailable

 > Could not resolve com.google.actions:actions-on-google:1.8.0-2m.
         > Could not get resource 'http://dl.bintray.com/2m/maven/com/google/actions/actions-on-google/1.8.0-2m/actions-on-google-1.8.0-2m.pom'.
            > Could not GET 'http://dl.bintray.com/2m/maven/com/google/actions/actions-on-google/1.8.0-2m/actions-on-google-1.8.0-2m.pom'.
               > dl.bintray.com:80 failed to respond

I added like described in the build Gradle file

repositories {
  maven {
    url 'http://dl.bintray.com/2m/maven'
  }
  mavenCentral()
  jcenter()
}
dependencies {
  implementation 'com.google.actions:actions-on-google:1.8.0-2m'
}

Anyway, where can I edit that SmartHomeApp.kt file,
I can't find it anywhere
Screen Shot 2022-04-28 at 2 00 52 AM

@2m
Copy link
Author

2m commented Apr 28, 2022

looks like the link of bintray is unavailable

Yea, bintray was shutdown since then.

I stopped working on this PR since I am not using this project anymore in my home automation.

Feel free to take it over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants