Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove registration-only runners #859

Closed
toast-gear opened this issue Sep 30, 2021 · 3 comments · Fixed by #1028
Closed

Remove registration-only runners #859

toast-gear opened this issue Sep 30, 2021 · 3 comments · Fixed by #1028
Labels
Milestone

Comments

@toast-gear
Copy link
Collaborator

Description
Since GitHub changed their routing logic to not fail pipelines that target a runs-on label that doesn't have a runner registered these are no longer needed

This work will also close some bugs linked with these pods:

@toast-gear toast-gear added enhancement New feature or request refactor and removed enhancement New feature or request labels Sep 30, 2021
@toast-gear toast-gear pinned this issue Oct 4, 2021
@FearlessHyena
Copy link
Contributor

FearlessHyena commented Oct 12, 2021

I'm not 100% sure but since GitHub Enterprise Server usually gets updated a few months later (compared to the Cloud version) it might still be using the old routing logic

@toast-gear
Copy link
Collaborator Author

toast-gear commented Oct 12, 2021

#470 (comment) I've just asked the Actions product owner in an old issue, not sure if he'll see it but worth a punt.

EDIT https://docs.github.com/en/enterprise-cloud@latest/actions/hosting-your-own-runners/using-self-hosted-runners-in-a-workflow#routing-precedence-for-self-hosted-runners you can select the Article version in the top right. When 3.3 comes out we should check the routing precedence again to see if the new logic made it to 3.3

EDIT We probably need to keep this logic for legacy setups, once 3.3 is out confirm via the documentation if the routing logic has changed and update the logic to use registration runners only on old GHES envs

EDIT https://docs.github.com/en/enterprise-server@3.3/actions/hosting-your-own-runners/using-self-hosted-runners-in-a-workflow#routing-precedence-for-self-hosted-runners the new routing logic is in the 3.3 docs, looks like we only registration runners for GitHub Server versions below 3.3 now

@toast-gear toast-gear changed the title Remove registration-only runners from codebase Use registration-only runners only on GitHub Server environments and only on versions below 3.3 Oct 24, 2021
@toast-gear toast-gear added this to the v0.21.0 milestone Nov 10, 2021
@toast-gear toast-gear changed the title Use registration-only runners only on GitHub Server environments and only on versions below 3.3 Remove registration-only runners Dec 3, 2021
@toast-gear
Copy link
Collaborator Author

toast-gear commented Dec 3, 2021

We are going to drop support for GHES below v3.3 and so the registration runners are no longer requried by any environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants