Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove registration runner dead code #1260

Merged
merged 4 commits into from
May 16, 2022

Conversation

toast-gear
Copy link
Collaborator

We had some dead code left over from the removal of registration runners. Registration runners were removed in #859 #1207

@toast-gear toast-gear changed the title refactor: registration runner dead code refactor: remove registration runner dead code Mar 22, 2022
@toast-gear toast-gear requested a review from mumoshu April 20, 2022 16:46
@mumoshu mumoshu force-pushed the refactor/registration-runner-logic branch from d2876db to 25da399 Compare May 11, 2022 23:30
@mumoshu mumoshu added this to the v0.24.0 milestone May 16, 2022
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution ☺️

@mumoshu mumoshu merged commit 65f7ee9 into master May 16, 2022
@mumoshu mumoshu deleted the refactor/registration-runner-logic branch May 16, 2022 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants