Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runner Scale Set listener-config secret is static #3182

Closed
4 tasks done
jb-2020 opened this issue Dec 20, 2023 · 0 comments · Fixed by #3195
Closed
4 tasks done

Runner Scale Set listener-config secret is static #3182

jb-2020 opened this issue Dec 20, 2023 · 0 comments · Fixed by #3195
Assignees
Labels
bug Something isn't working gha-runner-scale-set Related to the gha-runner-scale-set mode

Comments

@jb-2020
Copy link
Contributor

jb-2020 commented Dec 20, 2023

Checks

Controller Version

0.7.0

Deployment Method

Helm

Checks

  • This isn't a question or user support case (For Q&A and community support, go to Discussions).
  • I've read the Changelog before submitting this issue and I'm sure it's not due to any recently-introduced backward-incompatible changes

To Reproduce

1. Update the data in the `githubConfigSecret`
2. Force reconciliation (restart controller pod)

Describe the bug

After attempting to rotate the credentials used by the runner scale sets it was observed the data in the secret: *-listener-config is not automatically updated like the base secret: *-listener. This will cause issues if the old credentials are no longer valid.

Current work around is to manually delete the *-listener-config and force reconciliation

Describe the expected behavior

After the 'base' secret *-listener is updated the *-listener-config secret should also be updated.

Additional Context

N/A - it is worth noting that the static nature of this config secret also cause issues if the runner groups are updated or recreated.  If the associated runner group's ID is modified but the name is preserved you will also run into issues.  

This issue becomes quite painful if the old credentials are no longer valid, all listeners would then start throwing 401s.

Controller Logs

https://gist.github.com/jb-2020/bc063bcdead1e72ce44d4a0f0ceab32e

Runner Pod Logs

N/A
@jb-2020 jb-2020 added bug Something isn't working gha-runner-scale-set Related to the gha-runner-scale-set mode needs triage Requires review from the maintainers labels Dec 20, 2023
@nikola-jokic nikola-jokic removed the needs triage Requires review from the maintainers label Dec 21, 2023
@nikola-jokic nikola-jokic self-assigned this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gha-runner-scale-set Related to the gha-runner-scale-set mode
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants