Add annotation with values hash to re-create listener #3195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikola-jokic
requested review from
mumoshu,
toast-gear and
a team
as code owners
nikola-jokic
added
the
gha-runner-scale-set
nikola-jokic
commented
Jan 5, 2024
| @@ -250,12 +250,6 @@ type AutoscalingRunnerSetStatus struct { | |||
| FailedEphemeralRunners int `json:"failedEphemeralRunners"` | |||
| } | |||
|
|
|||
| func (ars *AutoscalingRunnerSet) ListenerSpecHash() string { | |||
There was a problem hiding this comment.
Note: This does not take into account live patches to the listener itself. If we need to calculate the hash spec live as well, I propose using shorter hash of the values.yaml spec and later add the suffix to the annotation based on the listener spec hash
nikola-jokic
force-pushed
the
nikola-jokic/listener-hash
branch
from
547489a
to
ca2d566
Compare
rentziass
previously approved these changes
Mar 19, 2024
rentziass
approved these changes
Mar 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using spec hash of the autoscaling runner set is not sufficient to indicate re-creation of the listener. As it is described in issue #3182, changing values.yaml to update secret does not re-create the listener.
Since we have avoided using cluster role to watch secrets, controller does not always have permission to list secrets (for more information, you can read this ADR).
Since all upgrades to the autoscaling runner set, initiated from helm, should re-create the listener, we can use the values json hash to create a fingerprint of the applied configuration. Instead of autoscaling runner set's spec hash, we can match the label against the installation to figure out if the listener should be re-created.
Fixes #3182