Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable automatic runner updates #1088

Merged
merged 4 commits into from Feb 3, 2022

Conversation

cbui
Copy link
Contributor

@cbui cbui commented Feb 3, 2022

Closes #1086

I tested by setting the runner version in the images to 2.287.0, toggling the flag, and seeing if it would update when given a job.

Once this work is complete self-updating would be preferred.

@toast-gear by this do you mean disabling autoupdate by default?

@cbui cbui changed the title Disable automatic updates feat: disable automatic updates Feb 3, 2022
@cbui cbui changed the title feat: disable automatic updates feat: disable automatic runner updates Feb 3, 2022
runner/entrypoint.sh Outdated Show resolved Hide resolved
@toast-gear
Copy link
Collaborator

@toast-gear by this do you mean disabling autoupdate by default?

As in keep the current behavior, runner's should self-update.

runner/entrypoint.sh Outdated Show resolved Hide resolved
@toast-gear
Copy link
Collaborator

LGTM cheers pal

@toast-gear toast-gear merged commit 1b91174 into actions:master Feb 3, 2022
@cbui cbui deleted the disable-automatic-updates branch February 3, 2022 21:04
@toast-gear
Copy link
Collaborator

Avoids the need for #888

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for new disable update flag
3 participants