Enhance RunnerSet to optionally retain PVs accross restarts #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumoshu
force-pushed
the
retain-pv-across-restarts-runnerset
branch
from
45334c8
to
be40479
Compare
|
looks very promising indeed, although I don't see how acceptance/testdata converts into an actual test of this implementation. |
|
@erplsf What do you mean by "actual test of this implementation"? It's used as a part of |
1 task
mumoshu
force-pushed
the
retain-pv-across-restarts-runnerset
branch
from
be40479
to
c815c00
Compare
This is our initial attempt to bring back the ability to retain PVs across runner pod restarts when using RunnerSet. The implementation is composed of two new controllers, `runnerpersistentvolumeclaim-controller` and `runnerpersistentvolume-controller`. It all starts from our existing `runnerset-controller`. The controller now tries to mark any PVCs created by StatefulSets created for the RunnerSet. Once the controller terminated statefulsets, their corresponding PVCs are clean up by `runnerpersistentvolumeclaim-controller`, then PVs are unbound from their corresponding PVCs by `runnerpersistentvolume-controller` so that they can be reused by future PVCs createf for future StatefulSets that shares the same same StorageClass. Ref #1286
…nnerSet + PVs Ref #1286
mumoshu
force-pushed
the
retain-pv-across-restarts-runnerset
branch
from
c815c00
to
6997357
Compare
|
Merging this anyway so that you can test the |
Gentoli
reviewed
May 23, 2022
| ) | ||
|
|
||
| // RunnerPersistentVolumeReconciler reconciles a PersistentVolume object | ||
| type RunnerPersistentVolumeReconciler struct { |
There was a problem hiding this comment.
Is watching PersistentVolumes necessary? Should it be up to the PV controller to decide how to reclaim/recreate when PVs the PVC is deleted.
| return ctrl.Result{}, client.IgnoreNotFound(err) | ||
| } | ||
|
|
||
| log.Info("Reconciling runner pvc") |
There was a problem hiding this comment.
This confusingly logs PVC skipped in syncPVC.
mumoshu
added a commit
that referenced
this pull request
May 25, 2022
* doc: Use RunnerSet to retain various cache In relation to #1286 and as a follow-up for #1340 * docs: clarify client vs daemon * docs: better wording * Separate RunnerSet examples for docker iimage layer caching * Revert changes on testdata as it is going to be added via #1471 instead * Update README.md Co-authored-by: Callum Tait <15716903+toast-gear@users.noreply.github.com> * fixup! Update README.md * Remove the outdated RunnerSet limitation Co-authored-by: Callum Tait <15716903+toast-gear@users.noreply.github.com>
cablespaghetti
pushed a commit
to cablespaghetti/actions-runner-controller
that referenced
this pull request
Jun 22, 2022
…1464) * doc: Use RunnerSet to retain various cache In relation to actions#1286 and as a follow-up for actions#1340 * docs: clarify client vs daemon * docs: better wording * Separate RunnerSet examples for docker iimage layer caching * Revert changes on testdata as it is going to be added via actions#1471 instead * Update README.md Co-authored-by: Callum Tait <15716903+toast-gear@users.noreply.github.com> * fixup! Update README.md * Remove the outdated RunnerSet limitation Co-authored-by: Callum Tait <15716903+toast-gear@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my initial attempt to bring back the ability to retain PVs across runner pod restarts when using RunnerSet.
The implementation is composed of two new controllers,
runnerpersistentvolumeclaim-controllerandrunnerpersistentvolume-controller.It all starts from our existing
runnerset-controller. The controller now tries to mark any PVCs created by StatefulSets created for the RunnerSet.Once the controller terminated statefulsets, their corresponding PVCs are clean up by
runnerpersistentvolumeclaim-controller. Shortly after that, PVs are unbound from their corresponding PVCs byrunnerpersistentvolume-controllerso that they can be reused by future PVCs created for future StatefulSets that share the same StorageClass.Ref #1286