Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Removed the default githubEvent: {} requiring a event to be defined #1361

Merged
merged 1 commit into from
Apr 24, 2022

Conversation

soham4abc
Copy link
Contributor

Fixes #1358

@mumoshu mumoshu added this to the v0.23.0 milestone Apr 22, 2022
@mumoshu mumoshu changed the title Removed the default githubEvent: {} requiring a event to be defined doc: Removed the default githubEvent: {} requiring a event to be defined Apr 24, 2022
@mumoshu
Copy link
Collaborator

mumoshu commented Apr 24, 2022

@soham4abc Thanks for the PR! Please also see #1379 for the code change required to make this documentation enhancement true.

Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution!

@mumoshu mumoshu merged commit e8ef84a into actions:master Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the default githubEvent: {} requiring a event to be defined
2 participants