Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forgot to do the chart #1388

Merged
merged 2 commits into from
Apr 29, 2022
Merged

fix: forgot to do the chart #1388

merged 2 commits into from
Apr 29, 2022

Conversation

toast-gear
Copy link
Collaborator

No description provided.

@toast-gear toast-gear requested a review from mumoshu April 25, 2022 20:00
@mumoshu
Copy link
Collaborator

mumoshu commented Apr 26, 2022

Linking #1294 and #1308

@mumoshu mumoshu added this to the v0.23.0 milestone Apr 26, 2022
@mumoshu
Copy link
Collaborator

mumoshu commented Apr 26, 2022

chart test is failing due to flag provided but not defined: -default-scale-down-delay which seems to come from the fact that we still use ARC 0.22.3 for chart testing.

Probably we'd better figure out how to test it against both the latest release version of ARC and the canary version of ARC?

Or just test it against the canary version so that it won't fail when the chart depends on features that are available only in the canary version of ARC? 🤔

@toast-gear toast-gear merged commit 55369bf into master Apr 29, 2022
@toast-gear toast-gear deleted the fix/sync-period-helm branch April 29, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants