Allow customizing the controller webhook port #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumoshu
reviewed
May 16, 2022
main.go
Outdated
| @@ -113,6 +114,7 @@ func main() { | |||
| flag.StringVar(&c.RunnerGitHubURL, "runner-github-url", c.RunnerGitHubURL, "GitHub URL to be used by runners during registration") | |||
| flag.DurationVar(&gitHubAPICacheDuration, "github-api-cache-duration", 0, "DEPRECATED: The duration until the GitHub API cache expires. Setting this to e.g. 10m results in the controller tries its best not to make the same API call within 10m to reduce the chance of being rate-limited. Defaults to mostly the same value as sync-period. If you're tweaking this in order to make autoscaling more responsive, you'll probably want to tweak sync-period, too") | |||
| flag.DurationVar(&defaultScaleDownDelay, "default-scale-down-delay", controllers.DefaultScaleDownDelay, "The approximate delay for a scale down followed by a scale up, used to prevent flapping (down->up->down->... loop)") | |||
| flag.IntVar(&port, "port", 9443, "The port to which the endpoint should bind") | |||
There was a problem hiding this comment.
Suggested change
| flag.IntVar(&port, "port", 9443, "The port to which the endpoint should bind") | |
| flag.IntVar(&port, "port", 9443, "The port to which the admission webhook endpoint should bind") |
We might better clarify it this way so that you can differentiate it from e.g. metrics port!
mumoshu
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1314
I was initially having some issues performing local testing, as the contribution guide and
Makefileare (at least in-part) still structured around amakerule (docker-build) that was removed recently. Considering the relatively small scope of this PR, I thought it would be easier to submit it, then go back and fix anything I had missed.