Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 1621:discover runner statuses feature to dind image #1624

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

bigwheel
Copy link
Contributor

@bigwheel
Copy link
Contributor Author

I tried to build image for test but it failed in my mac.
https://gist.github.com/bigwheel/6bd5d844dc30d04241ff7b843f67400a
Is this my environment problem ?

@bigwheel
Copy link
Contributor Author

dup #1623

mumoshu
mumoshu previously approved these changes Jul 11, 2022
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for your contribution!
I've already merged #1623 but I slightly prefer this as this is more consistent with the other dockerfile! Let me use this as the final result 😄

@mumoshu
Copy link
Collaborator

mumoshu commented Jul 11, 2022

Is this my environment problem ?

Yeah maybe. My quick googling seems to be telling that it might be caused by a network issue in your environment.
microsoft/WSL#5491
actions/runner-images#5519

Is that the case for you? 🤔

@bigwheel
Copy link
Contributor Author

bigwheel commented Jul 11, 2022

Yeah maybe. My quick googling seems to be telling that it might be caused by a network issue in your environment.
microsoft/WSL#5491
actions/runner-images#5519

Is that the case for you? 🤔

Perhaps. I exchanged macbook from intel to m1 in july and docker set up is not finished yet (I installed docker for mac to build this today). Ignore my build failure please.

@mumoshu mumoshu merged commit 98b17dc into actions:master Jul 12, 2022
@bigwheel bigwheel deleted the fix-1621 branch July 12, 2022 00:28
@mumoshu mumoshu mentioned this pull request Jul 12, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants