Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't base64 decode secret strings #1683

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

oreonl
Copy link
Contributor

@oreonl oreonl commented Aug 1, 2022

I was trying to use the new multi-tenancy functionality in the canary release but was getting an error
2022-08-01T22:51:51Z ERROR Reconciler error {"controller": "horizontalrunnerautoscaler-controller", "controllerGroup": "actions.summerwind.dev", "controllerKind": "HorizontalRunnerAutoscaler", "horizontalRunnerAutoscaler": {"name":"xxxxxxx","namespace":"actions-runner-system"}, "namespace": "actions-runner-system", "name": "xxxxxxx", "reconcileID": "2c994235-92be-40f9-bc42-4f0ada10247c", "error": "strconv.ParseInt: parsing \"\\xdbm\\xf8\\xd3\": invalid syntax"}

The controller is trying to base64 decode the secret values even though they are already being returned unencoded.

I built a docker image from this PR and was able to successfully do multi-tenancy.

Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I very much appreciate you for testing and fixing it! Thank you.
A contribution of this kind greatly helps quicken the new release of ARC ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants