fix: don't base64 decode secret strings #1683
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to use the new multi-tenancy functionality in the canary release but was getting an error
2022-08-01T22:51:51Z ERROR Reconciler error {"controller": "horizontalrunnerautoscaler-controller", "controllerGroup": "actions.summerwind.dev", "controllerKind": "HorizontalRunnerAutoscaler", "horizontalRunnerAutoscaler": {"name":"xxxxxxx","namespace":"actions-runner-system"}, "namespace": "actions-runner-system", "name": "xxxxxxx", "reconcileID": "2c994235-92be-40f9-bc42-4f0ada10247c", "error": "strconv.ParseInt: parsing \"\\xdbm\\xf8\\xd3\": invalid syntax"}
The controller is trying to base64 decode the secret values even though they are already being returned unencoded.
I built a docker image from this PR and was able to successfully do multi-tenancy.