Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dockerEnabled document #193

Merged
merged 2 commits into from
Nov 17, 2020
Merged

add dockerEnabled document #193

merged 2 commits into from
Nov 17, 2020

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Nov 16, 2020

In #191 , I forgot to document new feature, dockerEnabled.
this PR documents the feature.

@Warashi Warashi mentioned this pull request Nov 16, 2020
Merged
@callum-tait-pbx
Copy link
Contributor

callum-tait-pbx commented Nov 16, 2020 •
edited

Is this worded right? # If set to false, there are no privileged container but you cannot use docker.. Weird wordering, I would expect and you cannot use docker or but you can use docker. @Warashi

@Warashi
Copy link
Contributor Author

Warashi commented Nov 16, 2020

Sorry for my poor English. I fixed as suggested.

mumoshu
mumoshu approved these changes Nov 17, 2020
View reviewed changes
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Warashi No need to say sorry 😄 Thanks a lot for the improvement!

@mumoshu mumoshu merged commit 6ce6737 into actions:master Nov 17, 2020
@Warashi Warashi deleted the feature/document-dockerEnabled branch November 19, 2020 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumoshu mumoshu mumoshu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Warashi @callum-tait-pbx @mumoshu