GetRegistrationToken: Remove 10 minute buffer to token expiration #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumoshu
approved these changes
Nov 30, 2020
There was a problem hiding this comment.
@ZacharyBenamram I just read #77 (comment) - Impressed by your insight! Thanks for your efforts 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theres been a few outstanding issues related to runner pods not deleting due to token updates blocking the reconcile function as well as too many calls being made to the github api (#77 and #206).
I'm not sure of the original intention behind the buffer, but it can safely be removed all together and reduce the number of retries on the runner queue.
Below is a graph of the total number of reconcile retries made before and after the change with 2 runner pods:
