-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reposity name and full name for prometheus labels in actions metrics #2218
Merged
mumoshu
merged 4 commits into
actions:master
from
kirillbilchenko:reposity_labels_for_actionmetrics
Feb 25, 2023
Merged
Add reposity name and full name for prometheus labels in actions metrics #2218
mumoshu
merged 4 commits into
actions:master
from
kirillbilchenko:reposity_labels_for_actionmetrics
Feb 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirillbilchenko
requested review from
mumoshu,
toast-gear,
a team and
nikola-jokic
as code owners
January 27, 2023 09:53
kirillbilchenko
force-pushed
the
reposity_labels_for_actionmetrics
branch
from
January 30, 2023 10:44
6ddca7a
to
9c59b49
Compare
mumoshu
reviewed
Feb 21, 2023
mumoshu
reviewed
Feb 21, 2023
@kirillbilchenko Thanks for your support! I've also added my own commit for even more extensive nil checks. e65904d |
mumoshu
approved these changes
Feb 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for your contribution @kirillbilchenko
Apparently, we had to include those new labels into the metrics definitions. See #2225 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more labels for produced metrics, to be able to build better dashboards, based on repository and organization.