Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reposity name and full name for prometheus labels in actions metrics #2218

Merged

Conversation

kirillbilchenko
Copy link
Contributor

@kirillbilchenko kirillbilchenko commented Jan 27, 2023

Add more labels for produced metrics, to be able to build better dashboards, based on repository and organization.

@kirillbilchenko kirillbilchenko force-pushed the reposity_labels_for_actionmetrics branch from 6ddca7a to 9c59b49 Compare January 30, 2023 10:44
@Link- Link- added the needs triage Requires review from the maintainers label Jan 31, 2023
@mumoshu
Copy link
Collaborator

mumoshu commented Feb 25, 2023

@kirillbilchenko Thanks for your support! I've also added my own commit for even more extensive nil checks. e65904d

Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution @kirillbilchenko ☺️

@mumoshu
Copy link
Collaborator

mumoshu commented Mar 13, 2023

Apparently, we had to include those new labels into the metrics definitions. See #2225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Requires review from the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants