Add E2E test to assert self-signed CA support. #2458
Conversation
TingluoHuang
force-pushed
the
users/tihuang/cae2e
branch
from
78635ed
to
c39914f
Compare
TingluoHuang
force-pushed
the
users/tihuang/cae2e
branch
from
c39914f
to
63de2e3
Compare
| @@ -65,7 +65,7 @@ githubConfigSecret: | |||
| # certificateFrom: | |||
| # configMapKeyRef: | |||
| # name: config-map-name | |||
| # key: ca.pem | |||
| # key: ca.crt | |||
There was a problem hiding this comment.
update-ca-certificate only checks files with .crt extension.
https://manpages.ubuntu.com/manpages/xenial/man8/update-ca-certificates.8.html
| --name mitmproxy \ | ||
| --publish 8080:8080 \ | ||
| -v ${{ github.workspace }}/mitmproxy:/home/mitmproxy/.mitmproxy \ | ||
| mitmproxy/mitmproxy:latest \ |
There was a problem hiding this comment.
mitmproxy/mitmproxy:latest can decrypt HTTP requests, I am using that as the self-signed CA test server.
| --set "githubServerTLS.certificateFrom.configMapKeyRef.name=ca-cert" \ | ||
| --set "githubServerTLS.certificateFrom.configMapKeyRef.key=mitmproxy-ca-cert.crt" \ | ||
| --set "githubServerTLS.runnerMountPath=/usr/local/share/ca-certificates/" \ |
TingluoHuang
requested review from
mumoshu,
toast-gear,
a team and
nikola-jokic
as code owners
| kubectl create namespace arc-runners | ||
| kubectl -n arc-runners create configmap ca-cert --from-file="${{ github.workspace }}/mitmproxy/mitmproxy-ca-cert.crt" | ||
| kubectl -n arc-runners get configmap ca-cert -o yaml | ||
| ARC_NAME=${{github.job}}-$(date +'%M%S')$((($RANDOM + 100) % 100 + 1)) |
There was a problem hiding this comment.
| ARC_NAME=${{github.job}}-$(date +'%M%S')$((($RANDOM + 100) % 100 + 1)) | |
| ARC_NAME=${{github.job}}-$(date +'%M%S')$(($RANDOM % 100 + 1)) |
Do we need + 100? This should also work fine as far as I know
There was a problem hiding this comment.
+100, so you always get 3 digit number. 😄 not required.
There was a problem hiding this comment.
I know but I tested to see if it is okay to have for example:
echo $((5 % 100 + 1))that would result in:
6
If you prefer this, ignore my suggestion
There was a problem hiding this comment.
I will keep this for now. if we want to change, we will change all other jobs to follow the same pattern in a different PR. 😄
No description provided.