Check if appID and instID are non-empty before attempting to parseInt #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sthomson-wyn
requested review from
mumoshu,
toast-gear,
a team and
nikola-jokic
as code owners
mumoshu
approved these changes
Apr 2, 2023
|
@mumoshu no problem, I see the "first-interaction" workflow failed. Is there something additional that I need to do to get all of the checks passed? |
|
@sthomson-wyn No worry- that workflow is for commenting on the pull request for a first-time contributor for some guidance and seemingly it isn't working due to some permissions issues... which can be addressed later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2462